Re-enabling use of bonemeal on grass

grimper12341 · Post by **grimper12341** » Mon Sep 17, 2012 2:42 pm

To get tall grass and flowers. Those 2 things are a big part of my aesthetics when designing a base, bare grass is boring and lifeless. All the other bonemeal changes I approve of, but this one I can't see the reasoning behind it, it's purely an aesthetic thing that makes bases prettier :(

Poppycocks · Post by **Poppycocks** » Mon Sep 17, 2012 2:45 pm

http://sargunster.com/btw/index.php?title=Planter

You can grow tall grass and flowers out of a grass planter. You can harvest whatever it grows with a block dispenser.

Post by **Sarudak** » Mon Sep 17, 2012 2:46 pm

You can also harvest tall grass with shears.

grimper12341 · Post by **grimper12341** » Mon Sep 17, 2012 2:59 pm

Poppycocks wrote:http://sargunster.com/btw/index.php?title=Planter

You can grow tall grass and flowers out of a grass planter. You can harvest whatever it grows with a block dispenser.

" If left unoccupied, Grass Planters will also *eventually* sprout flowers (either red or yellow) and tall grass on their own"

"Eventually" isn't good enough to cover miles of terrain.

As for shears, that defeats the whole purpose. I don't want to destroy existing landscape features.

Post by **FlowerChild** » Mon Sep 17, 2012 3:01 pm

Mainly I removed that to make dyes a little more valuable, and because the insta-grow wasn't consistent with the rest of the changes I made to bone meal.

I *may* do something for the application of bone meal to grass in a way that is more consistent in the future, but it would likely require the use of an additional blockID.

grimper12341 · Post by **grimper12341** » Mon Sep 17, 2012 3:21 pm

Is there some kind of temporary work around you could enact in the mean time? Like decreasing the time it takes glass planters to grow grass/flowers maybe?

morvelaira · Post by **morvelaira** » Mon Sep 17, 2012 3:27 pm

grimper, you just got politely told that he'd consider your request some time in the future. If you continue to pester him, it will turn to, "No." Just be glad for what you may have in the future and let it lie.

grimper12341 · Post by **grimper12341** » Mon Sep 17, 2012 3:38 pm

Easy morv, your noob detector is getting a bit overly sensitive, I've been around for a while and know how this works :p

Not trying to pester anyone, first thread about it and last time I made a suggestion was 6+ months ago, I'm happy that he's considering it and just trying to offer some alternatives.

morvelaira · Post by **morvelaira** » Mon Sep 17, 2012 3:45 pm

I'm well aware you've been around here for quite a while. It's why I worded that as politely as I did. I'm trying to tell you that this path you take is perilous - which is something even old hands need reminding of sometimes.

Post by **FlowerChild** » Mon Sep 17, 2012 3:57 pm

After thinking this over a bit, I'm just going to re-enable the functionality as it previously was for the time being. The impact on the tech tree is minimal at best, and honestly, I was surprised at how important this feature was to people.

I'll likely rework it later once the extended block IDs become available, but for now, you're right in that there's no solid reason for it to be disabled at present if it's putting people out.

grimper12341 · Post by **grimper12341** » Mon Sep 17, 2012 4:07 pm

Awesome thanks a lot FC ^^

Post by **FlowerChild** » Mon Sep 17, 2012 4:32 pm

grimper12341 wrote:Awesome thanks a lot FC ^^

No problem man. You aren't the first to mention it as being important to them, and I don't generally deprive people just to get my jollies ;)

Post by **sargunv** » Mon Sep 17, 2012 4:50 pm

Awesome, thanks!

I use this feature for decoration quite a bit it it'll be great to have it back.

Post by **FlowerChild** » Mon Sep 17, 2012 5:01 pm

sargunster wrote:Awesome, thanks!

I use this feature for decoration quite a bit it it'll be great to have it back.

It's already back in, and I just tested it by coating a hill ;)

Was just a five minute thing, mostly me copy/pasting Mojang's code and cleaning it up. While I'm all about being practical about coding, I just can't handle having a "goto" sitting around in my code ;)

Post by **Sarudak** » Mon Sep 17, 2012 5:04 pm

FlowerChild wrote: Was just a five minute thing, mostly me copy/pasting Mojang's code and cleaning it up. While I'm all about being practical about coding, I just can't handle having a "goto" sitting around in my code ;)

I would bet that there's no goto in the original code. I remember doing a project once where I had to do a lot of decompiling because the source code we had was different from the production code. The decompiler would throw in a lot of "goto" statements in place of things like try/catch/finally blocks. It really had me scratching my head before i figured that out.

Post by **FlowerChild** » Mon Sep 17, 2012 5:13 pm

Sarudak wrote: I would bet that there's no goto in the original code. I remember doing a project once where I had to do a lot of decompiling because the source code we had was different from the production code. The decompiler would throw in a lot of "goto" statements in place of things like try/catch/finally blocks. It really had me scratching my head before i figured that out.

It's certainly possible, but in this case it really doesn't look like it. Take a look at the code for bone-meal growing grass and you'll see what I mean. It looks like it would demand a state-tracking variable that just isn't present to avoid the goto, as it's being used to bomb out of a two-deep nested for loop.

Thorium-232 · Post by **Thorium-232** » Mon Sep 17, 2012 5:24 pm

FlowerChild wrote:It looks like it would demand a state-tracking variable that just isn't present to avoid the goto, as it's being used to bomb out of a two-deep nested for loop.

Without even looking at the code that makes me cry inside.

Post by **FlowerChild** » Mon Sep 17, 2012 5:28 pm

Thorium-232 wrote: Without even looking at the code that makes me cry inside.

<shrug> I've used a goto in that manner precisely once like that in my career, and despite it being around 15 years ago I remember it well because I soul-searched on it for about a week :)

The thing was, it was in the innermost rendering loop of a software-based 3D engine, and after much consideration I decided that it was worth it because testing a separate state variable would obviously be slower.

So there *is* a place for that kind of thing in coding on occasion, and in this case, Notch's version of the code *is* faster. However, it's also in an area of the game where speed isn't even vaguely a concern.

Anyways, I don't want this to devolve into a general uninformed coding discussion, and this thread has served its purpose, so I'm locking it down.

Re-enabling use of bonemeal on grass

Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass

Re: Re-enabling use of bonemeal on grass